52 add delete user route #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nourshoreibah
previously approved these changes
Nov 7, 2025
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Great work Rayna!
mehanana
previously approved these changes
Nov 12, 2025
Contributor
mehanana
left a comment
mehanana
left a comment
There was a problem hiding this comment.
looks good and is well tested!
Rayna-Yu
dismissed stale reviews from mehanana and nourshoreibah
via
2bd7ed4
nourshoreibah
approved these changes
Nov 18, 2025
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Also looks great! One note: These are missing the unit tests in the testing guide, but this PR was opened before we made that guide I believe so all good. We will go back and add them later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
Closes #52
📝 Description
Added the delete user route
Briefly list the changes made to the code:
✔️ Verification
I wrote a couple of jest tests that all passed and also tested the route in swagger:
🏕️ (Optional) Future Work / Notes